Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

valueAsDate: unsupported on Chrome for datetime-local #36815

Merged
merged 3 commits into from
Feb 2, 2025
Merged

valueAsDate: unsupported on Chrome for datetime-local #36815

merged 3 commits into from
Feb 2, 2025

Conversation

simon04
Copy link
Contributor

@simon04 simon04 commented Nov 15, 2024 •
edited
Loading

@simon04 simon04 requested a review from a team as a code owner November 15, 2024 21:57
@simon04 simon04 requested review from wbamberg and removed request for a team November 15, 2024 21:57
@github-actions github-actions bot added Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed labels Nov 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024 •
edited
Loading

Preview URLs

External URLs (1)

URL: /en-US/docs/Web/API/HTMLInputElement/valueAsDate
Title: HTMLInputElement: valueAsDate property

(comment last updated: 2025-01-24 04:11:59)

@wbamberg
Copy link
Collaborator

Thanks for your PR, and sorry to be slow reviewing. We try to avoid making statements about specific browser support in the body of MDN pages, and instead represent that using BCD. So I think it would be better to add a subfeature to the compat data for this method (https://github.com/mdn/browser-compat-data/blob/31a53d119ed35cb9c97385b68c2ef15c784fcd92/api/HTMLInputElement.json#L3048) to the effect that it isn't supported in Chromium for datetime-local inputs.

@bsmth bsmth added the awaiting response Awaiting for author to address review/feedback label Dec 31, 2024
@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/xs [PR only] 0-5 LoC changed labels Jan 24, 2025
@Josh-Cena
Copy link
Member

Josh-Cena commented Jan 24, 2025 •
edited
Loading

While I agree that specific browser support information should live in BCD, the content should be greatly expanded because there are a lot of footguns here. @wbamberg do you think the current version looks fine?

@Josh-Cena Josh-Cena removed the awaiting response Awaiting for author to address review/feedback label Jan 24, 2025
Josh-Cena
Josh-Cena approved these changes Feb 2, 2025
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to merge for now since it connects quite closely to the Temporal introduction

@Josh-Cena Josh-Cena merged commit b3255d8 into mdn:main Feb 2, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@wbamberg wbamberg Awaiting requested review from wbamberg wbamberg is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simon04 @wbamberg @Josh-Cena @bsmth